Skip to content

Modify the issue association flow and Issue display #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2025
Merged

Modify the issue association flow and Issue display #4349

merged 3 commits into from
Jun 5, 2025
+28 −12

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented May 30, 2025 •
edited
Loading

Description

part of #4332

  • move the issue card above the branch card
  • when no issue is associated, display an element with "Current work item" on the left and the issue icon to the right.
  • when the issue icon is hovered, display a tooltip with "Associate an issue"
  • when the issue icon is clicked, open the issue association flow
  • when an issue is associated, display the issue card
  • modify the current issue card to be shorter than the other cards (reduce the top/bottom padding to 4px from 8px)

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue May 30, 2025 that may be closed by this pull request
Simplify work item section of Home View #4332
Closed
14 tasks
sergeibbb added a commit that referenced this pull request May 30, 2025
@sergeibbb
Moves the issue card above the branch card
8471114 
(#4332, #4349)
sergeibbb added a commit that referenced this pull request May 30, 2025
@sergeibbb
Modifies issue row when no issue is associated with the active branch
9ccf41d 
(#4332, #4349)
@sergeibbb sergeibbb force-pushed the 4332-issue-display branch from e2d86df to 2edfbf8 Compare May 30, 2025 17:47
sergeibbb added a commit that referenced this pull request May 30, 2025
@sergeibbb
Modifies the current issue card to be shorter than the other cards
2edfbf8 
reduces the top/bottom padding to 4px from 8px
(#4332, #4349)
@sergeibbb sergeibbb requested a review from d13 May 30, 2025 17:47
sergeibbb added a commit that referenced this pull request Jun 2, 2025
@sergeibbb
Moves the issue card above the branch card
c5de243 
(#4332, #4349)
sergeibbb added a commit that referenced this pull request Jun 2, 2025
@sergeibbb
Modifies issue row when no issue is associated with the active branch
5688f7c 
(#4332, #4349)
@sergeibbb sergeibbb force-pushed the 4332-issue-display branch from 2edfbf8 to 5e34028 Compare June 2, 2025 10:50
sergeibbb added a commit that referenced this pull request Jun 2, 2025
@sergeibbb
Modifies the current issue card to be shorter than the other cards
5e34028 
reduces the top/bottom padding to 4px from 8px
(#4332, #4349)
@sergeibbb sergeibbb mentioned this pull request Jun 2, 2025
Closed
14 tasks
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Moves the issue card above the branch card
8056444 
(#4332, #4349)
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Modifies issue row when no issue is associated with the active branch
f952a64 
(#4332, #4349)
@sergeibbb sergeibbb force-pushed the 4332-issue-display branch from 5e34028 to 01139a7 Compare June 3, 2025 12:30
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Modifies the current issue card to be shorter than the other cards
01139a7 
reduces the top/bottom padding to 4px from 8px
(#4332, #4349)
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Modifies issue row when no issue is associated with the active branch
a82f269 
(#4332, #4349)
@sergeibbb sergeibbb force-pushed the 4332-issue-display branch from 01139a7 to cbf87b9 Compare June 3, 2025 13:17
sergeibbb added a commit that referenced this pull request Jun 3, 2025
@sergeibbb
Modifies the current issue card to be shorter than the other cards
cbf87b9 
reduces the top/bottom padding to 4px from 8px
(#4332, #4349)
@sergeibbb
Copy link
Member Author

@d13

I've updated the PR. The old version modified issues in recent branches as well as in the current one. Now it's fixed.

d13
d13 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@d13 d13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a conflict resolution

@sergeibbb sergeibbb force-pushed the 4332-issue-display branch from cbf87b9 to adf3476 Compare June 5, 2025 16:25
@sergeibbb sergeibbb merged commit b1676c7 into main Jun 5, 2025
3 checks passed
sergeibbb added a commit that referenced this pull request Jun 5, 2025
@sergeibbb
Moves the issue card above the branch card
30be0e7 
(#4332, #4349)
sergeibbb added a commit that referenced this pull request Jun 5, 2025
@sergeibbb
Modifies issue row when no issue is associated with the active branch
8e9273b 
(#4332, #4349)
@sergeibbb sergeibbb deleted the 4332-issue-display branch June 5, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d13 d13 d13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify work item section of Home View

2 participants

@sergeibbb @d13